Creative thinking
1x
2 Issues Created
2x
16 Issues Created
3x
128 Issues Created
4x
1024 Issues Created
Problem Solving
1x
2 Pulls Created
2x
16 Pulls Created
3x
128 Pulls Created
4x
1024 Pulls Created
Practical/Professional Skills
Communication Skills
1x
100th Community Interaction
2x
1000th Community Interaction
3x
10000th Community Interaction
Collaboration
1x
2 Pulls Created
2x
16 Pulls Created
3x
128 Pulls Created
4x
1024 Pulls Created
Community Engagement
1x
100 Activity Points
2x
1000 Activity Points
3x
10000 Activity Points
Leadership
1x
Promoted to a team leader
Learn How to Learn
1x
Completed the course work
Skills to apply digital & technology solutions
1x
1 Project Completed Successfully
2x
2 Projects Completed Successfully
3x
3 Projects Completed Successfully
Critical Thinking
Autonomy And Responsibility
1x
2 issues identified and resolved
2x
16 issues identified and resolved
3x
128 issues identified and resolved
4x
1024 issues identified and resolved
Empathy
Value inculcation
Multicultural Competence
Individual Skills
Creative thinking
Problem Solving
Practical/Professional Skills
Team Skills
Communication Skills
Collaboration
Community Engagement
Leadership
Learn How to Learn
Skills to apply digital & technology solutions
Critical Thinking
Advanced Skills
Autonomy And Responsibility
Empathy
Value inculcation
Multicultural Competence
Cultural Skills
Still waiting for this
0 in last 7 days
0 in last 7 days
0 in last 7 days
N/A
Yet to make contributions!
Shared a comment on a pull request in coronasafe/care_fe on February 2, 2024 at 4:55:34 AM
The bug also happens on the live version of care. https://care.ohc.network hence wasn't introduced by this pr. @nihal467 @rithviknishad
https://github.com/coronasafe/care_fe/pull/6911#issuecomment-1922818940
Shared a comment on a pull request in coronasafe/care_fe on January 23, 2024 at 8:49:07 AM
@rithviknishad @nihal467 @Ashesh3 The issue being session expired page navigates to "/" and then since the session has expired it loads the session expired page again anyway which again navigates to "/", If the token is invalid i don't understand the need for checking the IsAuthenthicated and returning a navigate.
https://github.com/coronasafe/care_fe/pull/6911#issuecomment-1905578260
Shared a comment on a pull request in coronasafe/care_fe on January 19, 2024 at 1:21:35 PM
```js export default function SessionExpired() { const { signOut, user } = useAuthContext(); const isAuthenticated = Boolean(user); const navigate = useNavigate(); const { t } = useTranslation(); useEffect(() => { Notification.closeAllNotifications(); }, []); if (isAuthenticated) { navigate("/"); } ``` The bug seems to be due to the navigate("/") and i cannot understand why we need it? If the session has expired do we not wish to log the user out on the same page and show session expired with a return to login?
https://github.com/coronasafe/care_fe/pull/6911#issuecomment-1900417872
Shared a comment on a pull request in coronasafe/care_fe on January 13, 2024 at 7:13:39 AM
@rithviknishad The tests should work now.
https://github.com/coronasafe/care_fe/pull/6911#issuecomment-1890354031
Shared a comment on a pull request in coronasafe/care_fe on January 12, 2024 at 6:14:42 AM
Done! used the `devdistrictadmin` login instead.
https://github.com/coronasafe/care_fe/pull/6911#issuecomment-1888494639
Shared a comment on a pull request in coronasafe/care_fe on January 12, 2024 at 6:08:35 AM
Yep that too works.
https://github.com/coronasafe/care_fe/pull/6911#issuecomment-1888489999
Shared a comment on a pull request in coronasafe/care_fe on January 12, 2024 at 6:01:47 AM
Okay, found it! The staffdev login isn't available in the [dummy data](https://github.com/coronasafe/care/blob/master/data/dummy/users.json) that's loaded to the backend. Also there is just a devstaff2 username in the dummy data, no devstaff / devstaff1? The password on there is encrypted so do we proceed by adding a devstaff to the dummy data? or is the login info for devstaff2 noted somewhere?
https://github.com/coronasafe/care_fe/pull/6911#issuecomment-1888483982
Shared a comment on a pull request in coronasafe/care_fe on January 11, 2024 at 8:08:27 PM
I don't understand why the tests are failing with a POST 401 on github actions ![redirect -- Check if login redirects to the right url (failed) (attempt 2)](https://github.com/coronasafe/care_fe/assets/76207818/f37e879f-c0a6-41f6-9925-fbd1da104130) The same tests pass on local ![image](https://github.com/coronasafe/care_fe/assets/76207818/71150ca6-39b7-4742-aeb0-b203a0f7eb8e)
https://github.com/coronasafe/care_fe/pull/6911#issuecomment-1887885806
Shared a comment on a pull request in coronasafe/care_fe on December 27, 2023 at 6:16:04 AM
> @Om-Thorat > > Didn't this one line change ([#6911 (comment)](https://github.com/coronasafe/care_fe/pull/6911#issuecomment-1868988181)) alone solve the original issue? Was there some other issues? I did change the line to that but there had to be the reserved URLs change because of that rest much isn't changed.
https://github.com/coronasafe/care_fe/pull/6911#issuecomment-1869986212
Shared a comment on a pull request in coronasafe/care_fe on December 26, 2023 at 9:28:45 AM
@rithviknishad This new function works with both the redirect param and the direct urls , When an invalid redirect param is provided with a valid base url, The app chooses to discard the param and simply navigate to the valid base url Instead. The session expired redirects to the redirect param if available. It seems like there should be a test for the redirect param as well?
https://github.com/coronasafe/care_fe/pull/6911#issuecomment-1869402860
Shared a comment on a pull request in coronasafe/care_fe on December 26, 2023 at 8:01:00 AM
Sorry for the oversight before added a check to ensure that the redirect param redirects to a site that has the same origin as the current site, Not using this could have let malformed urls to be able to redirect to any sites they please ,potentially malicious.
https://github.com/coronasafe/care_fe/pull/6911#issuecomment-1869346102
Shared a comment on a pull request in coronasafe/care_fe on December 25, 2023 at 2:16:40 PM
> You could do the following: > > 1. If a redirect query param is present, use that. (Same as original implementation). > > 2. If redirect query param is not present, simply call the `signIn` method from `useAuth` when the login button is clicked without doing a navigate. (Since it's very likely that the we need to land in the current route itself, just that we need to cause a re-render the AuthProvider component. as required clicking on the button signs out and redirects to the page which then loads a login screen since the user is signed out, In the other case that a query param isn't present the url will just be `/session-expired` which should redirect to ` /`?
https://github.com/coronasafe/care_fe/pull/6911#issuecomment-1869003456
Shared a comment on a pull request in coronasafe/care_fe on December 25, 2023 at 2:02:50 PM
> So that means, the only code change required to fix this would be: The new redirector function doesn't check for a redirect param anymore so, There'll be that to fix as well
https://github.com/coronasafe/care_fe/pull/6911#issuecomment-1868998334
Shared a comment on a pull request in coronasafe/care_fe on December 25, 2023 at 1:13:34 PM
> Now that you've removed the support for `redirect` param completely, the "Session Expired" workflow wouldn't work this way right, since that still relies on the `redirect` param on the login page route? Hmm, How do we plan on dealing with that? Should we just redirect them to the same page and bring up the login screen?
https://github.com/coronasafe/care_fe/pull/6911#issuecomment-1868980508
Shared a comment on a pull request in coronasafe/care_fe on December 25, 2023 at 1:00:52 PM
not sure why run failed since it passed on local, looking into it. ![image](https://github.com/coronasafe/care_fe/assets/76207818/b05218d1-6380-441a-a043-354ced5b9671)
https://github.com/coronasafe/care_fe/pull/6911#issuecomment-1868975268
Shared a comment on an issue in coronasafe/care_fe on December 25, 2023 at 11:44:43 AM
Great! I'll get to it
https://github.com/coronasafe/care_fe/issues/6900#issuecomment-1868945881
Shared a comment on an issue in coronasafe/care_fe on December 25, 2023 at 11:15:10 AM
@rithviknishad This is a code design decision seems like the component expects an extra ?redirect= param at the end of string to redirect to, This isn't needed since the login page is shown on the same url that the user intends to go to. One way would be to redirect to the login page with a redirect param or another easier way might be to just use current url and just redirect to that after login.
https://github.com/coronasafe/care_fe/issues/6900#issuecomment-1868934714
Shared a comment on an issue in coronasafe/care_fe on December 25, 2023 at 11:02:38 AM
@rithviknishad Can you assign this to me? ```tsx const getRedirectURL = () => { return new URLSearchParams(window.location.search).get("redirect"); }; ``` The problem is probably the getRedirectURL function which always returns null
https://github.com/coronasafe/care_fe/issues/6900#issuecomment-1868929531